Skip to content

Commit 828e2da

Browse files
committedMay 23, 2023
refactor(form/inputs): simplify tenary statement
As suggested by @binoy14 in his review.
1 parent 6c7c4e4 commit 828e2da

File tree

4 files changed

+4
-17
lines changed

4 files changed

+4
-17
lines changed
 

‎packages/sanity/src/core/form/inputs/PortableText/object/Annotation.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,7 @@ export function Annotation(props: AnnotationProps) {
9696
[Markers, markers, renderCustomMarkers, text, validation]
9797
)
9898

99-
const presence =
100-
memberItem?.node.presence && memberItem?.node.presence.length > 0
101-
? memberItem.node.presence
102-
: EMPTY_ARRAY
99+
const presence = memberItem?.node.presence?.length ? memberItem.node.presence : EMPTY_ARRAY
103100

104101
const isOpen = Boolean(memberItem?.member.open)
105102
const input = memberItem?.input

‎packages/sanity/src/core/form/inputs/PortableText/object/BlockObject.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,7 @@ export function BlockObject(props: BlockObjectProps) {
123123
const parentSchemaType = editor.schemaTypes.portableText
124124
const hasMarkers = Boolean(markers.length > 0)
125125

126-
const presence =
127-
memberItem?.node.presence && memberItem?.node.presence.length > 0
128-
? memberItem.node.presence
129-
: EMPTY_ARRAY
126+
const presence = memberItem?.node.presence?.length ? memberItem.node.presence : EMPTY_ARRAY
130127

131128
// Tooltip indicating validation errors, warnings, info and markers
132129
const tooltipEnabled = hasError || hasWarning || hasInfo || hasMarkers

‎packages/sanity/src/core/form/inputs/PortableText/object/InlineObject.tsx

+1-5
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,7 @@ export const InlineObject = (props: InlineObjectProps) => {
7676

7777
const isOpen = Boolean(memberItem?.member.open)
7878
const input = memberItem?.input
79-
const presence =
80-
memberItem?.node.presence && memberItem?.node.presence.length > 0
81-
? memberItem.node.presence
82-
: EMPTY_ARRAY
83-
79+
const presence = memberItem?.node.presence?.length ? memberItem.node.presence : EMPTY_ARRAY
8480
const componentProps: BlockProps | undefined = useMemo(
8581
() => ({
8682
__unstable_boundaryElement: boundaryElement || undefined,

‎packages/sanity/src/core/form/inputs/PortableText/text/TextBlock.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,7 @@ export function TextBlock(props: TextBlockProps) {
147147

148148
const isOpen = Boolean(memberItem?.member.open)
149149
const parentSchemaType = editor.schemaTypes.portableText
150-
const presence =
151-
memberItem?.node.presence && memberItem?.node.presence.length > 0
152-
? memberItem.node.presence
153-
: EMPTY_ARRAY
150+
const presence = memberItem?.node.presence?.length ? memberItem.node.presence : EMPTY_ARRAY
154151

155152
const CustomComponent = schemaType.components?.block as ComponentType<BlockProps> | undefined
156153
const componentProps: BlockProps = useMemo(

0 commit comments

Comments
 (0)
Failed to load comments.