fix(base): skip cross dataset validation on mutations #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjelfull
requested review from
skogsmaskin and
bjoerge
and removed request for
bjoerge and
skogsmaskin
bjoerge
approved these changes
Nov 14, 2022
sjelfull
deleted the
bug/sc-26727/studio-crashes-every-time-you-edit-cdr-document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change disables cross dataset validation on mutations in the studio. This is mainly done to prevent the studio crashing because the mutation fails when 1) There is a cross dataset in the document being mutated 2) The document referenced has been deleted in the target dataset.
What to review
Notes for release
This is a port from v3 of PR #3846