chore: deleted plugins that now live outside the monorepo #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* @sanity/code-input * @sanity/color-input * @sanity/dashboard * @sanity/google-maps-input * @sanity/language-filter
snorrees
force-pushed
the
remove-v3-plugins
branch
from
96d6994
to
3467581
Compare
skogsmaskin
pushed a commit
that referenced
this pull request
Dec 8, 2022
* @sanity/code-input * @sanity/color-input * @sanity/dashboard * @sanity/google-maps-input * @sanity/language-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following plugins will now live in individual repos, on a
studio-v2branch:They are all currently on npm as a prerelease 2.36.0-v2-studio.x, with
studio-v2tag.When this PR is merged the following will be done in each repo:
mainbranch (v3 version) will be configured to uselatesttagstudio-v2branch will be changed from prerelease to userange: 2.36.xin.releaserc.jsonlatesttag on npm,studio-v2tag on npmWhat was done in the standalone repos
studio-v2branch with all changes as featTested prerelease version in a v2 studio already configured for these plugins (not in the monorepo).
What to review
Do a double take on this: I have just deleted the packages here (and fixed one instance of code-input in jest-config).
There are various references to code-input in @sanity/cli (workarounds) which I have not touched.
Given that this builds, is this ok as is?
Notes for release
Probably not needed, since nothing (should) have changed to the packages.
The version numbers will no longer be in sync with v2 releases though.