Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass readOnly to select element #3900

Merged
merged 1 commit into from Dec 21, 2022
Merged

Conversation

mariuslundgard
Copy link
Member

Description

Pass on readOnly property to the Select element.

What to review

Check that read only works as intended for string input with select layout.

Notes for release

Bugfix: pass readOnly to select element

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
test-studio ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 9:57AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
studio-workshop ⬜️ Ignored (Inspect) Nov 24, 2022 at 9:57AM (UTC)

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@skogsmaskin skogsmaskin deleted the branch next December 8, 2022 13:40
@skogsmaskin skogsmaskin closed this Dec 8, 2022
@mariuslundgard mariuslundgard reopened this Dec 8, 2022
@mariuslundgard mariuslundgard changed the base branch from v3 to next December 8, 2022 13:46
@mariuslundgard mariuslundgard changed the base branch from next to 2.x-next December 8, 2022 13:52
@rexxars rexxars removed the v3 label Dec 19, 2022
@hermanwikner hermanwikner changed the base branch from 2.x-next to next December 21, 2022 12:04
@mariuslundgard mariuslundgard merged commit f70736f into next Dec 21, 2022
@mariuslundgard mariuslundgard deleted the fix/select-input-read-only branch December 21, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants