Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-builder): remove distinctUntilChanged function from handleQueryChange in referenceInput #3901

Merged
merged 1 commit into from Nov 25, 2022

Conversation

ninaandal
Copy link
Contributor

Description

Removed the distinctUntilChanged function call from the handleQueryChange in the ReferenceInput to fix the issue of filtering not being updated when the parent component is changed.

Link to issue: #3217

What to review

The book reference dropdown is updated when the decade is changed without the need of a hard refresh.
ie try to go from 1980 to 10 (there are actual books for these decades to show)

Screenshot 2022-11-24 at 17 25 50

Notes for release

fix(form-build): Fix reference filtering updas

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
studio-workshop ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 4:30PM (UTC)
test-studio ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 4:30PM (UTC)

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the thoughtful comment.

@ninaandal ninaandal merged commit 0aeb3bb into next Nov 25, 2022
@ninaandal ninaandal deleted the bug/reference-field-filter-update branch November 25, 2022 09:06
skogsmaskin pushed a commit that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants