chore(form): replace react-sortable-hoc with dndkit #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bjoerge
force-pushed
the
chore/sc-25473/replace-react-sortable-hoc-for-sortable-arrays
branch
from
7804c32
to
776ec99
Compare
stipsan
approved these changes
Dec 15, 2022
bjoerge
force-pushed
the
chore/sc-25473/replace-react-sortable-hoc-for-sortable-arrays
branch
from
776ec99
to
3c8fd87
Compare
packages/sanity/src/core/form/inputs/arrays/ArrayOfObjectsInput/item/ItemCard.tsx
Outdated
Show resolved
Hide resolved
bjoerge
force-pushed
the
chore/sc-25473/replace-react-sortable-hoc-for-sortable-arrays
branch
from
3c8fd87
to
e602888
Compare
bjoerge
deleted the
chore/sc-25473/replace-react-sortable-hoc-for-sortable-arrays
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces react-sortable-hoc with the more modern and capable dndkit for reordering items in arrays in the studio editor.
It's only an internal refactoring and should not affect any customized studios. The UI should for the most part stay the same except for a couple of visual improvements.
What to review
Make sure drag to reorder array items works for:
Notes for release