Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate v2 modules #3997

Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 19, 2022

Description

We now have a range of npm modules that are no longer used as of Sanity Studio v3. While they still serve their original purpose for v2 studios, it is important for us to indicate that as of Sanity Studio v3, you no longer need for instance @sanity/desk-tool, since it is now part of the sanity module.

This PR adds a deprecation notice to the top of all deprecated @sanity-scoped modules that have been removed in the v3 release.

What to review

  • Copy
  • Whether or not all removed modules have been covered
  • Whether or not I have added the notice to any module that is not deprecated in v3

Notes for release

None.

@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
studio-workshop ✅ Ready (Inspect) Visit Preview Dec 19, 2022 at 11:50PM (UTC)
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 19, 2022 at 11:50PM (UTC)

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be good to have @hermanwikner's comment considered before merging.

@bjoerge bjoerge merged commit 0dba94b into 2.x-next Dec 21, 2022
@bjoerge bjoerge deleted the chore/sc-27449/add-banner-to-add-to-the-deprecated-packages branch December 21, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants