Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(titles): Update titles inside desk tool #4887

Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Aug 31, 2023

When the user is moving through documents and panes, update the title property to be more specific to the current route

Description

Update the <title> element to be more specific to the current route every time a user follows a link in the studio.
Changes titles to use pipes as divider, in the title structure, mention first the most unique thing.

  • Previously: Test Studio - Content
  • Updated: Content | Test Studio

Uses the following pattern:

  • Desk root: {{tool}} | {{desktoolTitle}}
  • Document list: {{paneTitle}} | {{desktoolTitle}}
  • Document: {{documentTitle}} | {{desktoolTitle}}
  • Document (new): New {{schemaTitle}} | {{desktoolTitle}}

What to review

Titles inside the studio, navigating through documents in the desk and also navigating between tools.

Notes for release

Update the <title> element to be more specific to the current route every time a user follows a link in the studio.

Titles.mov

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:28am
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 5:28am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 5:28am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Component Testing Report Updated Sep 6, 2023 5:28 AM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 11s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 42s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny tiny suggestion, otherwise looks great! Thanks @pedrobonamin!

Copy link
Contributor

@robinpyon robinpyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pedrobonamin – great work!

One minor issue is that the last document title isn't always displayed in the instance where multiple document panes are open. Here's an example link which should include "Zinken Hopsf!" in document.title

Once that's in I think this is good to go! I also submitted a PR against this which adds the above and refactors DeskTitle slightly – would love your thoughts, but also feel free to disregard

pedrobonamin and others added 4 commits September 6, 2023 07:23
@pedrobonamin pedrobonamin added this pull request to the merge queue Sep 6, 2023
Merged via the queue into next with commit 2ace4f1 Sep 6, 2023
16 checks passed
@pedrobonamin pedrobonamin deleted the feature/edx-92-all-pages-have-the-same-title-wcag-242 branch September 6, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants