Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desk): use index as key instead of path #4890

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Aug 31, 2023

Description

The validation document inspector currently uses the path as react key, assuming only one validation marker per path, which is not always the case. Couldn't find any unique value on the validation markers, so this fixes it by using index as key instead.

What to review

  • Make sure validation inspector can handle multiple validation errors for the same field/node

Notes for release

  • Fixes a react key error when having multiple validation errors for the same document node

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 6, 2023 1:37pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 1:37pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 1:37pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Component Testing Report Updated Sep 6, 2023 1:39 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 13s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 45s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@bjoerge bjoerge added this pull request to the merge queue Sep 6, 2023
Merged via the queue into next with commit 645aedd Sep 6, 2023
16 checks passed
@bjoerge bjoerge deleted the feature/sdx-716 branch September 6, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants