Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add aria-label to reference publish icons #4899

Merged
merged 4 commits into from Sep 12, 2023
Merged

fix(core): add aria-label to reference publish icons #4899

merged 4 commits into from Sep 12, 2023

Conversation

ninaandal
Copy link
Contributor

Description

Adding some aria-labels for accessibility.

What to review

Notes for release

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 8, 2023 2:20pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 2:20pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 2:20pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited

Component Testing Report Updated Sep 8, 2023 2:23 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 52s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@ninaandal ninaandal marked this pull request as ready for review September 8, 2023 10:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

No changes to documentation

@ninaandal ninaandal requested review from a team September 8, 2023 13:17
robinpyon
robinpyon approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@robinpyon robinpyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ninaandal – minor typo but otherwise LGTM

packages/sanity/src/desk/components/NotPublishedStatus.tsx Outdated Show resolved Hide resolved
@ninaandal @robinpyon
Update packages/sanity/src/desk/components/NotPublishedStatus.tsx
e11deea 
Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com>
@ninaandal ninaandal added this pull request to the merge queue Sep 12, 2023
Merged via the queue into next with commit 3153954 Sep 12, 2023
17 checks passed
@ninaandal ninaandal deleted the feature/edx-409-published-state-icon-has-no-text-alternative-wcag-111 branch September 12, 2023 08:17
rexxars pushed a commit that referenced this pull request Sep 12, 2023
@ninaandal @robinpyon @rexxars
fix(core): add aria-label to reference publish icons (#4899)
9abdd57 
* fix(core): add aria-label to reference publish icons

* fix(core): add aria-label to validation icons

* fix(core): add aria-label to presence avatar stack

* Update packages/sanity/src/desk/components/NotPublishedStatus.tsx

Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com>

---------

Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinpyon robinpyon robinpyon approved these changes

@bjoerge bjoerge bjoerge approved these changes

@binoy14 binoy14 binoy14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ninaandal @robinpyon @bjoerge @binoy14