Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): increase concurrency of patching, document creation #4900

Merged
merged 3 commits into from Sep 13, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 6, 2023

Description

We had some concurrency issues when strengthening references in parallel, but this hasn't been the case for years now. This improves the performance of the import by doing more strengthening in parallel.

What to review

  • Importing still works as expected

Notes for release

  • Improved performance of dataset imports using the sanity dataset import command/@sanity/import module

@rexxars rexxars requested a review from a team September 6, 2023 15:23
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 13, 2023 5:29pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 5:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2023 5:29pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Component Testing Report Updated Sep 13, 2023 5:31 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 11s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 43s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@bjoerge
Copy link
Member

bjoerge commented Sep 13, 2023

@rexxars is this good to merge?

@rexxars
Copy link
Member Author

rexxars commented Sep 13, 2023

@rexxars is this good to merge?

Just wanted to do a few tests to ensure we don't hit the rate limiter

@rexxars rexxars changed the title fix(import): increase reference strengthening concurrency to 30 fix(import): increase concurrency of patching, document creation Sep 13, 2023
@rexxars rexxars merged commit 0f52cfc into next Sep 13, 2023
15 of 16 checks passed
@rexxars rexxars deleted the feature/sdx-726-ref-increase branch September 13, 2023 17:29
@github-actions
Copy link
Contributor

No changes to documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants