chore(docs): compare PRs against next branch instead of current #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
binoy14
commented
Sep 7, 2023
| - name: Create Docs Report on current | ||
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/current' }} | ||
| - name: Create Docs Report on current or next | ||
| if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/current' || github.ref == 'refs/heads/next') }} |
There was a problem hiding this comment.
Not sure if the event_name is still push when a PR is merged. Does anyone know?
There was a problem hiding this comment.
Seems fair to assume so, esp. since there doesn't seem to be a merge event.
There was a problem hiding this comment.
It might be trial and error. I will merge and check
binoy14
commented
Sep 7, 2023
|
Component Testing Report Updated Sep 7, 2023 7:56 PM (UTC)
|
|
No changes to documentation |
- fixes token mismatch when deleting dataset - better message when no changes to documentation
binoy14
force-pushed
the
feature/sdx-727
branch
from
412bbff
to
99e4d45
Compare
bjoerge
approved these changes
Sep 7, 2023
| - name: Create Docs Report on current | ||
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/current' }} | ||
| - name: Create Docs Report on current or next | ||
| if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/current' || github.ref == 'refs/heads/next') }} |
There was a problem hiding this comment.
Seems fair to assume so, esp. since there doesn't seem to be a merge event.
|
oh just realized the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
The actions conditionals are valid
Notes for release
N/A