Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(import): fix test failure caused by error message update in node v20 #4918

Merged
merged 1 commit into from Sep 12, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Sep 11, 2023

Description

One of the tests in the @sanity/import package cufrently fails in node v20 due to JSON parse errors having a slightly different error message. This fixes it by using a regex that verifies the first part of the error message, which is unchanged between node v18 and v20.

What to review

Change looks ok, tests are passing

Notes for release

N/A

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 11, 2023 9:07pm
test-studio ✅ Ready (Inspect) Visit Preview Sep 11, 2023 9:07pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 11, 2023 9:07pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Sep 11, 2023 9:12 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 12s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 43s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@bjoerge bjoerge added this pull request to the merge queue Sep 12, 2023
Merged via the queue into next with commit 2f08a79 Sep 12, 2023
17 checks passed
@bjoerge bjoerge deleted the fix/import-package-test-failures-node-20 branch September 12, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants