-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_install_media_detect: allow separate detection of exe and exedb for installations where exedb isn't required #729
Comments
@rob0d @sean-freeman - According to the comments about Wouldn't a new value for The new behavior would be as follows:
This can be achieved by adding all possible database types for parameter community.sap_install/roles/sap_install_media_detect/tasks/prepare/create_file_list_phase_2.yml Line 138 in a97844d
community.sap_install/roles/sap_install_media_detect/tasks/find_files_after_extraction.yml Line 147 in a97844d
|
Solves issue sap-linuxlab#729. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Hi @berndfinger, yes this sounds better than what I suggested. I would just suggest to use 'none' instead of 'absent'. |
... for not detecting DB specific SAP kernel file(s) (SAPEXEDB) Relates to sap-linuxlab#729. Signed-off-by: Bernd Finger <bfinger@redhat.com>
@rob0d I agree: 'none' is better than 'absent', as the meaning of 'absent' in Ansible is typically to ensure that something is not available. |
Solved in #732. |
@sean-freeman as per your message to track this enhancement suggestion.
When set sap_install_media_detect_kernel the code in
sap_install_media_detect
currently detects both EXE and EXEDB parts of the SAP Kernel.Some types of installations don't require EXEDB, only EXE.
Suggestion is to change the behaviour to allow the kernel detection to separately check EXE or EXEDB or both.
Options probably depend on how much we care about backwards compatibility as
sap_install_media_detect_kernel
is used in many places.Option 1:
Allow more than just true/false, but keep true for compatibility purposes:
true
orall
exe
orpart1
exedb
orpart2
Option2:
Introduce new control parameters:
sap_install_media_detect_kernel_part1
+sap_install_media_detect_kernel_part2
ans possibly for backward compatibility keep
sap_install_media_detect_kernel
which will override the two new parameters if set to true. This may lead to a slightly confusing behaviour is the three parameters are not inline.The text was updated successfully, but these errors were encountered: