Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps)!: support for djs v14 #512

Merged
merged 4 commits into from Jan 8, 2023
Merged

feat(deps)!: support for djs v14 #512

merged 4 commits into from Jan 8, 2023

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Aug 23, 2022 •
edited by favna

Related:

Discord.js v14 support in Framework.

@favna favna mentioned this pull request Aug 23, 2022
Closed
@favna favna added this to the v4 milestone Aug 23, 2022
@favna favna linked an issue Aug 23, 2022 that may be closed by this pull request
request: update for DiscordJS v14 #513
Closed
1 task
@enffinity69
Copy link

Does this work with the sapphire cli?

@r-priyam
Copy link
Contributor

Does this work with the sapphire cli?

No, @sapphire/cli supports the latest stable release of @sapphire/framework and this PR is in alpha.

@enffinity69
Copy link

When will this PR be merged?

@favna
Copy link
Member

favna commented Aug 29, 2022

When will this PR be merged?

When it's ready

@enffinity69
Copy link

has any progress been made so far?

@favna
Copy link
Member

favna commented Sep 6, 2022

has any progress been made so far?

Please stop asking. If any progress is made you will be able to see that through the commit history of the PR.

@HarryAllen1
Copy link

Can this be published to NPM?

@favna
Copy link
Member

favna commented Oct 3, 2022

Can this be published to NPM?

there are branch conflicts and CI is failing so no. But you can make a PR to resolve those issues.

@vladfrangu vladfrangu force-pushed the feat/djs-v14 branch 2 times, most recently from fd99723 to 8cf67cf Compare October 7, 2022 20:15
@net-tech
Copy link

Unconfirmed, however, preconditions in text commands may not be working. Please see https://canary.discord.com/channels/737141877803057244/1047625479198359592 before replying.

@favna favna force-pushed the feat/djs-v14 branch 6 times, most recently from d02e5f0 to c15cf8a Compare December 30, 2022 18:17
@sapphiredev sapphiredev deleted a comment from vladfrangu Dec 30, 2022
@favna favna mentioned this pull request Dec 30, 2022
Merged
@favna favna marked this pull request as ready for review December 31, 2022 00:45
@favna favna requested a review from kyranet as a code owner December 31, 2022 00:45
@HarryAllen1
Copy link

Can the @sapphire/framework@pr-512 tag be updated with the latest changes?

@favna
Copy link
Member

favna commented Jan 2, 2023 •
edited

Can the @sapphire/framework@pr-512 tag be updated with the latest changes?

There are no changes since the last release @HarryAllen1. The bot comments have just been removed.

@favna
Copy link
Member

favna commented Jan 6, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented Jan 6, 2023

Heya @favna, I've started to run the deployment workflow on this PR at de20326. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Jan 6, 2023

Hey @favna, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-512

vladfrangu and others added 2 commits January 8, 2023 10:25
@vladfrangu @renovate
@favna @RealShadowNova @BenSegal855 @itsUrcute @Lioness100
feat(deps): support for discord.js v14
e57d91d 
fix(normalizeInputs): should not default default_permission anymore

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Claassens <support@favware.tech>
Co-authored-by: Hezekiah Hendry <hezekiah.hendry@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Ben <34194692+BenSegal855@users.noreply.github.com>
Co-authored-by: Urcute <75350256+itsUrcute@users.noreply.github.com>
Co-authored-by: Lioness100 <jchickmm2@gmail.com>
@favna
chore: update tsdoc
b289520
favna added a commit to sapphiredev/examples that referenced this pull request Jan 8, 2023
@favna
feat(deps): support for djs v14
0437528 
Related:
- [framework#512](sapphiredev/framework#512)
- [utilities#434](sapphiredev/utilities#434)
- [plugins#403](sapphiredev/plugins#403)

This PR brings updates the code for djs v14.
@favna favna mentioned this pull request Jan 8, 2023
Merged
favna
favna previously approved these changes Jan 8, 2023
View reviewed changes
@favna favna mentioned this pull request Jan 8, 2023
Merged
@favna favna merged commit e81cba2 into main Jan 8, 2023
@favna favna deleted the feat/djs-v14 branch January 8, 2023 13:43
@net-tech
Copy link

net-tech commented Jan 8, 2023 via email

@developomp
Copy link

🎉

@owocado
Copy link

owocado commented Jan 8, 2023

@davipatricio
Copy link

🚀

@developomp developomp mentioned this pull request Jan 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner

Assignees

@favna favna

@vladfrangu vladfrangu

Labels
chore dependencies discordjs documentation refactor semver:major tests
Projects
Sapphire
Status: Done
Milestone
v4
Development

Successfully merging this pull request may close these issues.

request: update for DiscordJS v14
9 participants
@vladfrangu @enffinity69 @r-priyam @favna @HarryAllen1 @net-tech @developomp @owocado @davipatricio