fix: reloading the entire command store didn't fire ApplicationCommandRegistries #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested review from
kyranet,
favna and
vladfrangu
as code owners
vladfrangu
changed the title
vladfrangu
previously approved these changes
Sep 4, 2022
|
@sapphiredev pack |
|
Hey @favna, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-525 |
|
@sapphiredev pack |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 0d23cd1. You can monitor the build here! |
|
Hey @vladfrangu, The bot has released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-525 |
favna
approved these changes
Oct 1, 2022
r-priyam
pushed a commit
to r-priyam/sapphire-framework
that referenced
this pull request
Oct 3, 2022
…dRegistries (sapphiredev#525) * fix: reloading the entire command store didn't fire ApplicationCommandRegistries * chore: smol fix * chore: add note on current unload behavior for future changes Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
|
Sorry for the necro-bump, but the npm package for the sapphire framework still has the https://www.npmjs.com/package/@sapphire/framework?activeTab=versions
|
|
Apparently CI failed for this PR, thanks NPM API for being unpredictable af. https://github.com/sapphiredev/framework/actions/runs/3169108831 Just deprecated it manually. Thanks for informing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandStore#loadAll()indirectly removes all application command registries. In addition, the Command'sapplicationCommandRegistrybeing readonly snapshots the command's old registry before it is removed.As a result, application command registries won't handle api calls after reloading the command store more than once.
This is a hacky patch that gets the job done, so draft pr is only for visibility in hopes of reaching a better solution.