fix(precondition): use result for PreconditionContainerSingle #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feefs
changed the title
vladfrangu
previously approved these changes
Sep 21, 2022
Oops I forgot to remove those after linting. Fixed! |
favna
previously approved these changes
Sep 21, 2022
kyranet
reviewed
Sep 23, 2022
kyranet
approved these changes
Sep 23, 2022
favna
requested changes
Sep 23, 2022
favna
approved these changes
Sep 23, 2022
vladfrangu
approved these changes
Oct 1, 2022
r-priyam
pushed a commit
to r-priyam/sapphire-framework
that referenced
this pull request
Oct 3, 2022
…redev#535) * fix(precondition): use result for PreconditionContainerSingle * fix: remove unnecessary async * fix: import err directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreconditionContainerSingle doesn't use result, so when command-specific preconditions that don't implement the corresponding run method are ran in CorePreChatInputCommandRun.ts the
ChatInputCommandDeniedevent isn't emitted (similar issue forCorePreMessageCommandRun.tsandCorePreContextMenuCommandRun.ts). The error propagates upwards and emits aListenerErrorevent instead.This uses an approach similar to PreconditionStore.ts for global preconditions to fix the issue.