feat(ApplicationCommandRegistries): add RegisterBehavior.BulkOverwrite which has Sapphire use bulk overwrite for registering Application Commands
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapphiredev pack this pls |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at b3215b2. You can monitor the build here! |
|
Hey @vladfrangu, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-585 |
|
PR tested with Sapphire's rotated cousin and it worked 🎉 but testers are welcome nevertheless |
favna
requested changes
Jan 4, 2023
src/lib/utils/application-commands/ApplicationCommandRegistries.ts
Outdated
Show resolved
Hide resolved
src/lib/utils/application-commands/ApplicationCommandRegistry.ts
Outdated
Show resolved
Hide resolved
favna
approved these changes
Jan 5, 2023
…s.ts Co-authored-by: Jeroen Claassens <support@favware.tech>
favna
force-pushed
the
feat/let-sapphire-handle-that-for-you
branch
from
b5b268f
to
4b6ef37
Compare
favna
approved these changes
Jan 5, 2023
favna
changed the title
RegisterBehavior.BulkOverwrite which has Sapphire use bulk overwrite for registering Application Commands
favna
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578
Closes #577
Closes #579 (Supersedes)