fix(computeDifferences): ensure Overwrite strategy is actually faster
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
requested changes
Jan 4, 2023
favna
approved these changes
Jan 4, 2023
kyranet
approved these changes
Jan 4, 2023
favna
changed the title
Overwrite strategy is actually faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way getCommandDifferencesFast was built made sense, returning when the first difference was found.
Only issue is that the method it actually used internally, which is the verbose difference one, would still process all differences in the command BEFORE returning, BEFORE getCommandDifferencesFast would see if any difference is present.
Basically it was faster in name only. Now it should actually be faster 馃