feat(plugin-i18next): add applyLocalizedBuilder and createSelectMenuChoiceName to help registering localized commands
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(plugin-i18next): port applyLocalizedBuilder and createSelectMenuChoiceName
Arcadia148
requested review from
Nytelife26,
favna and
kyranet
as code owners
favna
changed the title
applyLocalizedBuilder to help registering localized commands
favna
previously approved these changes
Oct 15, 2022
vladfrangu
requested changes
Oct 15, 2022
favna
changed the title
applyLocalizedBuilder to help registering localized commandsapplyLocalizedBuilder and createSelectMenuChoiceName to help registering localized commands
favna
approved these changes
Oct 15, 2022
vladfrangu
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports applyLocalizedBuilder from @skyra/http-framework-i18n
I did also consider having a resolveLocale function which would convert locales like "ja-JP" to ones assignable to type LocaleString. (https://github.com/Arcadia148/plugins/blob/feat/localizedBuilders2/packages/i18next/src/lib/functions.ts#L189)
This PR closes #353