fix: supportsXCommands() methods now use SubcommandMappings #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
supportsMessageCommands()
andsupportsChatInputCommands()
methods on the subcommand class. Previously, these both would always return true since the methods inherited from theCommand
class just check for the existence of amessageRun()
orchatInputRun()
method. Since both methods are implemented on theSubcommand
class, the type guards would always return true. This PR instead determines the output of these methods by checking if amessageRun
orchatInputRun
property was provided on any of the subcommands in theparsedSubcommandMappings
array. These changes were tested using commands with all combinations of having a messageRun, having a chatInputRun, having both, having groups, and not having groups. Test commands can be found in this gist.