fix(utilities): rename Awaited<T> to Awaitable<T>
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
approved these changes
Oct 4, 2021
favna
approved these changes
Oct 4, 2021
favna
changed the title
Awaited<T> to Awaitable<T>Awaited<T> to Awaitable<T>
favna
added a commit
to sapphiredev/framework
that referenced
this pull request
Oct 4, 2021
This matches the change made in sapphiredev/utilities#193 BREAKING CHANGE: `Awaited` type has been renamed to `Awaitable`
favna
added a commit
to sapphiredev/pieces
that referenced
this pull request
Oct 4, 2021
This matches the change made in sapphiredev/utilities#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/, we'll eventually run into a name conflict between the built-in
Awaited<T>type, and our type.This PR fixes the conflict by renaming our type to
Awaitable<T>