Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utilities): add sleep and sleepSync #469

Merged
merged 15 commits into from Oct 1, 2022
Merged

feat(utilities): add sleep and sleepSync #469

merged 15 commits into from Oct 1, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

This pr adds sleep and sleepAsync

I'm not using timers/promise just to make it browser compitible

favna
favna previously approved these changes Sep 30, 2022
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
@imranbarbhuiya imranbarbhuiya requested review from kyranet and favna and removed request for vladfrangu, kyranet and favna October 1, 2022 04:26
packages/utilities/tests/sleep.test.ts Outdated Show resolved Hide resolved
packages/utilities/tests/sleep.test.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/index.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Show resolved Hide resolved
packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu previously approved these changes Oct 1, 2022
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after kyra's suggestion is appplied

packages/utilities/src/lib/sleep.ts Outdated Show resolved Hide resolved
@favna favna changed the title feat: add sleep and sleepSync feat(utilities): add sleep and sleepSync Oct 1, 2022
@favna favna merged commit 8cd1293 into sapphiredev:main Oct 1, 2022
@imranbarbhuiya imranbarbhuiya deleted the feat/sleep branch October 1, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants