generated from sapphiredev/sapphire-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utilities): add sleep
and sleepSync
#469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imranbarbhuiya
requested review from
favna,
kyranet and
vladfrangu
as code owners
September 30, 2022 18:30
favna
previously approved these changes
Sep 30, 2022
kyranet
requested changes
Sep 30, 2022
imranbarbhuiya
requested review from
kyranet and
favna
and removed request for
vladfrangu,
kyranet and
favna
October 1, 2022 04:26
kyranet
requested changes
Oct 1, 2022
kyranet
requested changes
Oct 1, 2022
kyranet
requested changes
Oct 1, 2022
vladfrangu
previously approved these changes
Oct 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after kyra's suggestion is appplied
kyranet
requested changes
Oct 1, 2022
favna
approved these changes
Oct 1, 2022
vladfrangu
approved these changes
Oct 1, 2022
favna
changed the title
feat: add
feat(utilities): add Oct 1, 2022
sleep
and sleepSync
sleep
and sleepSync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds
sleep
andsleepAsync
I'm not using
timers/promise
just to make it browser compitible