Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utilities): add objectEntries function #471

Merged
merged 5 commits into from Oct 1, 2022
Merged

feat(utilities): add objectEntries function #471

merged 5 commits into from Oct 1, 2022

Conversation

RealShadowNova
Copy link
Contributor

Resolves #455

@RealShadowNova
Copy link
Contributor Author

Should I change the return type for the key to a string or to a template literal containing number in the case of an array?
image

favna
favna reviewed Oct 1, 2022
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template literal same as the other pr

vladfrangu
vladfrangu previously approved these changes Oct 1, 2022
View reviewed changes
favna
favna requested changes Oct 1, 2022
View reviewed changes
packages/utilities/src/lib/objectEntries.ts Outdated Show resolved Hide resolved
@favna favna merged commit 84c1418 into sapphiredev:main Oct 1, 2022
@RealShadowNova RealShadowNova deleted the feat/add-strictly-typed-object-entries branch October 1, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna requested changes

@kyranet kyranet kyranet requested changes

@imranbarbhuiya imranbarbhuiya imranbarbhuiya requested changes

@vladfrangu vladfrangu vladfrangu left review comments

Assignees
No one assigned
Labels
feature packages:utilities semver:minor
Projects
Sapphire
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: add objectEntries (a strictly typed Object.entries) to @sapphire/utilities
5 participants
@RealShadowNova @favna @vladfrangu @kyranet @imranbarbhuiya