Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utilities): add objectKeys function #472

Merged

Conversation

RealShadowNova
Copy link
Contributor

Resolves #457

packages/utilities/tests/objectKeys.test.ts Show resolved Hide resolved
@RealShadowNova
Copy link
Contributor Author

Should I change the return type to a string or to a template literal containing number in the case of an array?
image

@imranbarbhuiya
Copy link
Contributor

template literal containing number

favna
favna previously approved these changes Oct 1, 2022
vladfrangu
vladfrangu previously approved these changes Oct 1, 2022
favna
favna previously requested changes Oct 1, 2022
packages/utilities/src/lib/objectKeys.ts Outdated Show resolved Hide resolved
@favna favna force-pushed the feat/add-strictly-typed-object-keys branch from a5bc97a to 2ba349a Compare October 1, 2022 16:05
@favna favna dismissed stale reviews from kyranet and themself October 1, 2022 16:05

resolved

@favna favna enabled auto-merge (squash) October 1, 2022 16:06
@favna favna merged commit 384ff84 into sapphiredev:main Oct 1, 2022
@RealShadowNova RealShadowNova deleted the feat/add-strictly-typed-object-keys branch October 1, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

request: add objectKeys (a strictly typed Object.keys) to @sapphire/utilities
5 participants