feat(utilities): add objectValues function
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealShadowNova
requested review from
favna,
kyranet and
vladfrangu
as code owners
kyranet
previously requested changes
Sep 30, 2022
imranbarbhuiya
suggested changes
Oct 1, 2022
imranbarbhuiya
suggested changes
Oct 1, 2022
RealShadowNova
requested review from
kyranet and
imranbarbhuiya
and removed request for
favna,
vladfrangu,
kyranet and
imranbarbhuiya
imranbarbhuiya
previously approved these changes
Oct 1, 2022
favna
approved these changes
Oct 1, 2022
vladfrangu
reviewed
Oct 1, 2022
| @@ -0,0 +1,5 @@ | |||
| import type { NonNullObject } from './utilityTypes'; | |||
|
|
|||
| export function objectValues<T extends NonNullObject>(obj: T): T extends ArrayLike<any> ? T[number][] : T[keyof T][] { | |||
There was a problem hiding this comment.
Shouldn't this use T extends ArrayLike<infer Values> ? Values[] : T[keyof T][]?
There was a problem hiding this comment.
What is Values in this context?
vladfrangu
previously approved these changes
Oct 1, 2022
favna
requested changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #456