Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tryParseURL #482

Merged
merged 5 commits into from Oct 8, 2022
Merged

Conversation

legendhimself
Copy link
Contributor

@legendhimself legendhimself commented Oct 3, 2022

fixes: #481
Todo:

  • Write unit test

packages/utilities/package.json Show resolved Hide resolved
packages/utilities/src/lib/tryParseJSON.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/tryParseJSON.ts Outdated Show resolved Hide resolved
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest I had completely missed that we already had parseURL because I was looking for try... when I created the issue LMAO!!

Ohwell, ultimately we also got general improvements out of this PR

@favna favna merged commit 46c5b49 into sapphiredev:main Oct 8, 2022
@imranbarbhuiya
Copy link
Contributor

@favna I was just checking if there is any way to add deprecated jsdoc in re-export and found it

microsoft/TypeScript#42684

@favna
Copy link
Member

favna commented Oct 8, 2022

@favna I was just checking if there is any way to add deprecated jsdoc in re-export and found it

microsoft/TypeScript#42684

Oh can you make a PR for that then? Same for filterNullishOrZero and filterNullishOrEmpty (mind the OR, so not the AND variants)

goestav pushed a commit to goestav/utilities that referenced this pull request Jun 21, 2023
Co-authored-by: Jeroen Claassens <support@favware.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants