fix(utilities): race condition issue for closed paginated message #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the button components won't get removed due to a race condition error: `DiscordAPIError: Interaction has already been acknowledged.`. This occurs when trying to interact with the message when it is about to close the paginated message.
|
dunno what you see as spam clicking because it either works for me, or I get rate limited by Discord 18-23-36_08-10-2022_Discord.mp4 |
|
In general the code looks good but please attach a reproduction video recording because I cannot reproduce it |
Screen.Recording.2022-10-08.at.23.45.38.movI guess I didn't explain well, but it happens while the paginated message is getting closed |
favna
approved these changes
Oct 8, 2022
goestav
added a commit
to goestav/utilities
that referenced
this pull request
Jun 21, 2023
…pphiredev#484) * fix(utilities): race condition issue for closed paginated message This commit fixes a bug where the button components won't get removed due to a race condition error: `DiscordAPIError: Interaction has already been acknowledged.`. This occurs when trying to interact with the message when it is about to close the paginated message. Co-authored-by: Jeroen Claassens <support@favware.tech>
goestav
pushed a commit
to goestav/utilities
that referenced
this pull request
Jun 21, 2023
Regression issue caused by sapphiredev#484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where the button components won't get removed due to a race condition error:
DiscordAPIError: Interaction has already been acknowledged..This occurs when the user tries to interact with the message when the paginated message is about to close.
You can reproduce this by spam clicking the next/previous buttons on a paginated message.