New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utilities): add pickRandom #486

Merged

favna merged 9 commits into sapphiredev:main from Lioness100:main

Oct 8, 2022

Collaborator

Lioness100 commented Oct 8, 2022

No description provided.


          feat(utilities): add pickRandom

8f4c445

Lioness100 requested review from favna, kyranet and vladfrangu as code owners

October 8, 2022 12:13


          fix(utilities): update package.json

a999b46

imranbarbhuiya suggested changes

View reviewed changes

packages/utilities/src/lib/pickRandom.ts Outdated Show resolved Hide resolved


          feat(pickRandom): add count param

5e76db5

imranbarbhuiya suggested changes

View reviewed changes

packages/utilities/tests/pickRandom.test.ts Outdated Show resolved Hide resolved


          refactor(pickRandom): use expect.arrayContaining

a300079

imranbarbhuiya suggested changes

View reviewed changes

packages/utilities/src/lib/pickRandom.ts Outdated Show resolved Hide resolved


          chore: updated framework to the lattest version

853446f

permalink: http://whatthecommit.com/aee79930d5302fd48478704522be7eb3

favna previously approved these changes

View reviewed changes

imranbarbhuiya suggested changes

View reviewed changes

packages/utilities/src/lib/pickRandom.ts Outdated Show resolved Hide resolved


          chore: hmmm

84d3810

permalink: http://whatthecommit.com/d80df00961644ea75c3ce283ac3d7f32

favna dismissed their stale review via

84d3810

October 8, 2022 16:47


          chore: argh! about to give up :(

6e45a49

permalink: http://whatthecommit.com/beed88c162736b37e1a27a63fb115760

Lioness100 commented

View reviewed changes

packages/utilities/src/lib/pickRandom.ts Outdated Show resolved Hide resolved

Lioness100 commented

View reviewed changes

packages/utilities/src/lib/pickRandom.ts Outdated Show resolved Hide resolved

favna added 2 commits

October 8, 2022 19:03


          chore: git stash license.md node_modules package.json packages readme…

3dc603c

….md scripts tsconfig.base.json tsconfig.dev.json tsconfig.eslint.json turbo.json typedoc.json vitest.config.ts yarn.lock

permalink: http://whatthecommit.com/7ad7c71289d30791e2f20c54465142aa


          chore: this really should not take 19 minutes to build.

d0e8adc

permalink: http://whatthecommit.com/ff1dccf3e15376dc20ceafc1a977aebe

favna approved these changes

View reviewed changes

favna merged commit 20823c9 into sapphiredev:main

goestav pushed a commit to goestav/utilities that referenced this pull request


          feat(utilities): add pickRandom (sapphiredev#486)

e04c35e

Co-authored-by: Jeroen Claassens <support@favware.tech>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

imranbarbhuiya imranbarbhuiya requested changes

favna favna approved these changes

kyranet Awaiting requested review from kyranet kyranet is a code owner

vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner