Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discord-utilities): interaction option resolver #515

Merged
merged 7 commits into from Nov 1, 2022
Merged

feat(discord-utilities): interaction option resolver #515

merged 7 commits into from Nov 1, 2022

Conversation

didinele
Copy link
Contributor

No description provided.

@didinele didinele requested a review from favna as a code owner October 24, 2022 13:10
favna
favna requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things and as said above this needs some proper testing. I also want to go through the code and do some syntax changing to more match the sapphire style (I.e. we don't really use key in object generally)

packages/discord-utilities/package.json Outdated Show resolved Hide resolved
packages/discord-utilities/src/lib/CommandInteractionOptionResolver.ts Outdated Show resolved Hide resolved
packages/discord-utilities/src/lib/CommandInteractionOptionResolver.ts Outdated Show resolved Hide resolved
@didinele
Copy link
Contributor Author

as said above this needs some proper testing

Would you like me to write unit tests?

favna
favna previously approved these changes Oct 29, 2022
View reviewed changes
@didinele didinele changed the title feat(discord-utilities): command interaction option resolver feat(discord-utilities): interaction option resolver Oct 31, 2022
@didinele didinele force-pushed the feat/command-interaction-option-resolver branch 2 times, most recently from ae5dfdb to 9fb8dd7 Compare October 31, 2022 17:56
@didinele
Copy link
Contributor Author

Also rebased

@didinele didinele force-pushed the feat/command-interaction-option-resolver branch from 9fb8dd7 to d5a932d Compare October 31, 2022 18:00
@favna favna merged commit f3911e9 into sapphiredev:main Nov 1, 2022
@didinele didinele deleted the feat/command-interaction-option-resolver branch November 1, 2022 16:33
goestav pushed a commit to goestav/utilities that referenced this pull request Jun 21, 2023
@didinele @favna @goestav
feat(discord-utilities): interaction option resolver (sapphiredev#515)
20c3fce 
* feat(discord-utilities): command interaction option resolver

* fix(CommandInteractionOptionResolver): proper constructor type

* chore: consistent spacing

* fix(CommandInteractionOptionResolver): actually make required arg optional

* chore: add tests

* chore: hey, look over there!

permalink: http://whatthecommit.com/87cf7faa6a18dc6d7232dea310109684

* chore: rename

Co-authored-by: Jeroen Claassens <support@favware.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@didinele @favna @vladfrangu