perf(chunk): remove clone #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
force-pushed
the
perf/chunk/remove-clone
branch
from
61a16fc
to
a69d14b
Compare
favna
approved these changes
Apr 10, 2023
goestav
pushed a commit
to goestav/utilities
that referenced
this pull request
Jun 21, 2023
* perf(chunk): remove clone * fix: resolved bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on an array with 21 elements:
The updated function also uses half as much memory, as it doesn't clone the array. The performance improvement should be even greater on larger arrays, as removing (or inserting) elements at the start of an array is the slowest array operation.