Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PaginatedMessage): add support for per-page actions #587

Merged
merged 11 commits into from May 4, 2023

Conversation

killbasa
Copy link
Contributor

@killbasa killbasa commented May 1, 2023

Per-page components for PaginatedMessage are now supported.

Page actions can be added by using the 3 methods setPageActions, addPageActions, and addPageAction.

@killbasa killbasa changed the title Page components feat(PaginatedMessage): add support for per-page actions May 1, 2023
@favna
Copy link
Member

favna commented May 2, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented May 2, 2023

Heya @favna, I've started to run the deployment workflow on this PR at 0d75167. You can monitor the build here!

@favna
Copy link
Member

favna commented May 2, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented May 2, 2023

Heya @favna, I've started to run the deployment workflow on this PR at 03cfe5a. You can monitor the build here!

@favna
Copy link
Member

favna commented May 3, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented May 3, 2023

Heya @favna, I've started to run the deployment workflow on this PR at 205914b. You can monitor the build here!

@favna
Copy link
Member

favna commented May 4, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented May 4, 2023

Heya @favna, I've started to run the deployment workflow on this PR at e960766. You can monitor the build here!

@favna favna merged commit b917236 into sapphiredev:main May 4, 2023
8 checks passed
@killbasa killbasa deleted the page-components branch May 4, 2023 18:43
goestav pushed a commit to goestav/utilities that referenced this pull request Jun 21, 2023
…#587)

* feat(PaginatedMessage): add support for per-page actions

* fix(LazyPaginatedMessage): remove @returns line

* refactor: improve docs and allow including default actions with `setPageActions`

* docs: improve typedoc

* fix(PaginatedMessage): properly add page actions

* fix(PaginatedMessage): remove default actions from `setPageActions`

* fix(PaginatedMessage): properly defer interactions

* fix(PaginatedMessage): use previously resolved components in `updateCurrentPage`

* fix(PaginatedMessage): revert message edit change in `handleCollect`

* feat(PaginatedMessage): apply new components to updated page

* fix(PaginatedMessage): add `pageActions` to `clone`

---------

Co-authored-by: Jeroen Claassens <support@favware.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants