generated from sapphiredev/sapphire-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PaginatedMessage): add support for per-page actions #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killbasa
changed the title
Page components
feat(PaginatedMessage): add support for per-page actions
May 1, 2023
3 tasks
@sapphiredev pack |
@sapphiredev pack |
@sapphiredev pack |
@sapphiredev pack |
favna
approved these changes
May 4, 2023
goestav
pushed a commit
to goestav/utilities
that referenced
this pull request
Jun 21, 2023
…#587) * feat(PaginatedMessage): add support for per-page actions * fix(LazyPaginatedMessage): remove @returns line * refactor: improve docs and allow including default actions with `setPageActions` * docs: improve typedoc * fix(PaginatedMessage): properly add page actions * fix(PaginatedMessage): remove default actions from `setPageActions` * fix(PaginatedMessage): properly defer interactions * fix(PaginatedMessage): use previously resolved components in `updateCurrentPage` * fix(PaginatedMessage): revert message edit change in `handleCollect` * feat(PaginatedMessage): apply new components to updated page * fix(PaginatedMessage): add `pageActions` to `clone` --------- Co-authored-by: Jeroen Claassens <support@favware.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per-page components for
PaginatedMessage
are now supported.Page actions can be added by using the 3 methods
setPageActions
,addPageActions
, andaddPageAction
.