Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan for es3.d.ts #6

Closed
saschanaz opened this issue May 23, 2017 · 1 comment
Closed

Plan for es3.d.ts #6

saschanaz opened this issue May 23, 2017 · 1 comment

Comments

@saschanaz
Copy link
Owner

saschanaz commented May 23, 2017 •
edited

  1. lib.d.ts for es3, lib.es5.full.d.ts for es5
  2. fourslash baselines are for lib.d.ts, give fourslash test lib: es3 by default to suppress baseline changes as much as possible
  3. support @lib setting on fourslash test to allow setting @lib: es5 for ES5-requiring tests
  4. add a test to check @lib: es3 does not have ES5 types
saschanaz pushed a commit that referenced this issue Jun 18, 2021
@Kingwl @DanielRosenwasser
--noImplicitOverride (microsoft#39669)
2f0c8b2 
* wip: add types

* wip

* Add cases

* Add some case

* Add more check

* accept baseline

* add abstract abd declare method

* add override in declaration

* accept baseline

* add property override

* Fix decalre modifier

* update baseline

* Add more cases

* make lint happy

* make lint happy

* Update description

* Add codefix

* simplify code

* accept baseline

* Update desc

* Accept baseline

* Add override completions

* filter out implements field in override context

* fix tests

* Add parameter property check

* Accept baseline

* acept baseline

* Add parameter property to declaration code action

* Add quickfix for override parameter property

* fix code style

* Add override with interface tests

* Add more cases about modifier position

* rename flag

* rename flags

* Added tests.

* Accepted baselines.

* Always issue errors for unnecessary 'override' modifiers.

* Accepted baselines.

* Override perf (#4)

* try cache check result

* pre check for override

* Do not issue error if implement abstract

* Add abstract-spec check

* Avoid override dead lock

* Add more case

* Add codefix for new error

* Fix error message

* Add jsdoc override tag (#6)

* Override jsdoc tag (#7)

* accept baseline

* Disallow codefix in js

* update baseline

* Omit override in d.ts

* Add more case in js

* Accept baseline

* fix override js test

* fix crlf

* Revert merge conflict changes

* Accept baseline

* Avoid space

* Fix CR issues

* Accept baseline

* Fix typo and add more check

* Fix error name

Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
@saschanaz
Copy link
Owner Author

microsoft#28372 is rejected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saschanaz