Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsass 3.6 #2685

Open
aldarund opened this issue Jun 4, 2019 · 14 comments
Open

libsass 3.6 #2685

aldarund opened this issue Jun 4, 2019 · 14 comments
Labels
Module - Binding

Comments

@aldarund
Copy link

aldarund commented Jun 4, 2019

https://github.com/sass/libsass/releases/tag/3.6.0
@leefernandes
Copy link

https://github.com/sass/libsass/releases/tag/3.6.1

I forked node-sass to integrate the latest libsass 3.6.1 commit #2b8a17a, mocha tests fail, but it does build successfully, and I'm able to use new libsass features like @content arguments. #2714

@nex3 nex3 mentioned this issue Jul 24, 2019
Closed
5 tasks
@dylancopeland
Copy link

Is adding support for 3.6 anywhere on the roadmap?

@xzyfer
Copy link
Contributor

xzyfer commented Jul 25, 2019 via email

@KaelWD KaelWD mentioned this issue Aug 7, 2019
Closed
@mbaluda
Copy link

mbaluda commented Aug 14, 2019

libsass contains a HIGH severity vulnerability that is fixed in 3.6.0
https://nvd.nist.gov/vuln/detail/CVE-2018-19827
sass/libsass@b21fb9f

Can you provide a timeline for the update?

@ZebraFlesh
Copy link

libsass 3.6.0 also contains a fantastic bug fix sass/libsass#2849 that fixes some Windows specific compilation errors.

@Lab43
Copy link

Lab43 commented Sep 3, 2019

And it implements passing arguments to content blocks, which is super useful. https://sass-lang.com/documentation/at-rules/mixin#passing-arguments-to-content-blocks

@tyhal tyhal mentioned this issue Sep 3, 2019
Closed
@AdamNatale
Copy link

Is there any update on this?

@nschonni nschonni mentioned this issue Oct 5, 2019
Closed
@bricss
Copy link

bricss commented Oct 9, 2019

PR with upgrade is kinda waiting for several months, already ↪️ #2714

@saper
Copy link
Member

saper commented Oct 9, 2019

PR with upgrade is kinda waiting for several months, already arrow_right_hook #2714

Does not seem that way to me, sorry!

@nschonni nschonni changed the title libsass 3.6.0 libsass 3.6 Oct 9, 2019
@saper saper modified the milestone: 5.0 Oct 17, 2019
@saper
Copy link
Member

saper commented Oct 17, 2019 •
edited

@xzyfer @nschonni What do you think about producing a 4.x release with libsass 3.6.x? ah, we can't due to sass/libsass#2611

carlosvalle added a commit to GSA/sam-styles that referenced this issue Oct 17, 2019
@carlosvalle
fix: LibSass 3.5.4 inspect() bug
38e6e2c 
inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0
(sass/node-sass#2685)
While we wait for node-sass. We need to make sure that values that we
pass to the utilities mixins are exactly as described in _system-tokens.scss
@carlosvalle carlosvalle mentioned this issue Oct 17, 2019
Merged
carlosvalle added a commit to GSA/sam-styles that referenced this issue Oct 18, 2019
@carlosvalle
fix: LibSass 3.5.4 inspect() bug
8082c1b 
inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0
(sass/node-sass#2685)
While we wait for node-sass. We need to make sure that values that we
pass to the utilities mixins are exactly as described in _system-tokens.scss
@johnnyBira
Copy link

Is this happing any time soon? I'm looking forward to mixin content block arguemnts.
Thanks for making an maintaining this wonderful library <3

@karthikrajthandapani
Copy link

image
As per Azure Dev Ops report, libsass contains a HIGH severity vulnerability that is fixed in 3.6.0
Please can you provide timeline for the update?

@saper
Copy link
Member

saper commented Oct 30, 2019

@karthikrajthandapani this is a volunteer-run project, so no timelines are provided. Sorry.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 30, 2019 via email

@sass sass locked as spam and limited conversation to collaborators Oct 30, 2019
@nschonni nschonni pinned this issue Nov 26, 2019
@saper saper unpinned this issue Jan 14, 2020
@nschonni nschonni pinned this issue Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Module - Binding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests