chore: Add GitHub Actions for Alpine CI #2823
Conversation
|
This looks like something would do easily enough with Travis CI but I'm curious to see how this compares. |
| node: | ||
| - 6 | ||
| - 8.16.2 # Something in 8.17.0 is breaking NPM cache install | ||
| - 10 |
There was a problem hiding this comment.
Give #2822 we'll want to use 10.16
There was a problem hiding this comment.
I didn't run into this one in the testing, can you give an example of what Alpine version you hit the issue with?
There was a problem hiding this comment.
In the end the gist of the problem appears to be that binaries built on newer alpine version didn't work on older alpine versions. I think most alpine docker images come 3.9, 3.10, 3.11, so we'll probably want to build binaries in whatever the lowest is for the specific node version.
There was a problem hiding this comment.
OK, there are tags that include the Alpine version, so I can take a look at aligning that details to the run
There was a problem hiding this comment.
I've pinned them to the oldest versions now
nschonni
force-pushed
the
alpine-docker-build
branch
4 times, most recently
from
da2ad01
to
38fb64d
Compare
nschonni
force-pushed
the
alpine-docker-build
branch
from
38fb64d
to
7e1d443
Compare
|
Added v14, but it seems like GitHub is using an image cache that is missing it right now https://github.com/nschonni/node-sass/runs/607236373 |
|
I'm having the same issue trying to build the binary locally. Might be dockerhub struggling after today's EC2 issues. |
|
I've got the Linux and pax binaries built locally. I'll cut a minor release tonight. |
nschonni
force-pushed
the
alpine-docker-build
branch
from
7e1d443
to
ec5eff4
Compare
|
Looks like it's happy now https://github.com/nschonni/node-sass/actions/runs/85070002 |
|
Feel free to ship this when you're ready @nschonni |
|
This is super cool btw. |
|
Lets give it a shot. If it works out, we can cherrypick something for v5. It's possible that Actions could replace most of the CI once we don't need the old VS & Node versions there |
Adds some CI for the Alpine images to speed up releases.
If this works out, I might take a look at converting some of the others.
This also uploads the artifacts as a zip on successful builds. This could be modified to only run on tags later
Note: ran into an issue with the Node 8.17.0 alpine images. You can see an example log here https://gist.github.com/nschonni/491cd2ae724e1f24db3b76b37698ab1c
Main issues is probably around
where the git sass-spec is failing. Tried a bunch of troubleshooting, but just decided to pin to the previous version that was working.
PS: I don't think the CI will show up till this lands, but you can see the build here https://github.com/nschonni/node-sass/commit/c288e6067650d9ebd11980c6e320e8b409f422d8/checks?check_suite_id=407548884