Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for binary operations #1013

Open
nex3 opened this issue Dec 19, 2016 · 0 comments
Open

Add specs for binary operations #1013

nex3 opened this issue Dec 19, 2016 · 0 comments
Labels
tests to add

Comments

@nex3
Copy link
Contributor

nex3 commented Dec 19, 2016

All the binary operations need thorough tests that exercise their edge and error cases. Most existing specs in spec/parser/operations have individual lines that produce errors, which means that almost nothing is being tested in practice. I intend to remove those specs.

Ruby Sass has pretty good coverage for binary operations, which can be ported over.
nex3 added a commit that referenced this issue Dec 19, 2016
@nex3
Delete broken operation tests.
2d49fd8 
The deleted tests had large inputs in which one line errored and all
other lines were ignored, and as such weren't particularly useful. New
specs should be added for these; see #1013.
nex3 added a commit that referenced this issue Dec 19, 2016
@nex3
Delete broken operation tests.
373301e 
The deleted tests had large inputs in which one line errored and all
other lines were ignored, and as such weren't particularly useful. New
specs should be added for these; see #1013.
nex3 added a commit that referenced this issue Dec 19, 2016
@nex3
Delete broken operation tests.
fdec229 
The deleted tests had large inputs in which one line errored and all
other lines were ignored, and as such weren't particularly useful. New
specs should be added for these; see #1013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests to add
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nex3