Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for base importer without URL #1970

Closed
nex3 opened this issue Apr 9, 2024 · 1 comment · Fixed by #1972
Closed

Add tests for base importer without URL #1970

nex3 opened this issue Apr 9, 2024 · 1 comment · Fixed by #1972
Labels
enhancement

Comments

@nex3
Copy link
Contributor

nex3 commented Apr 9, 2024 •
edited

We can't test this deprecation directly because it's against the TypeScript types anyway, but we do need to update the deprecation list. Although this behavior has always worked for JS users, we haven't been able to test it because it's against the TypeScript types.
@nex3 nex3 mentioned this issue Apr 9, 2024
Open
3 tasks
nex3 added a commit that referenced this issue Apr 9, 2024
@nex3
Add the importer-without-url deprecation
7807829 
Closes #1970
@nex3 nex3 mentioned this issue Apr 9, 2024
Closed
@nex3
Copy link
Contributor Author

nex3 commented Apr 9, 2024

Per sass/dart-sass#2208 (comment), we've decided not to deprecate this after all.

@nex3 nex3 closed this as completed Apr 9, 2024
@nex3 nex3 reopened this Apr 9, 2024
@nex3 nex3 changed the title Update tests for base importer without URL deprecation Add tests for base importer without URL Apr 9, 2024
nex3 added a commit that referenced this issue Apr 9, 2024
@nex3
Add a test for an importer without a base URL
72be218 
Closes #1970
@nex3 nex3 mentioned this issue Apr 9, 2024
Merged
nex3 added a commit that referenced this issue Apr 9, 2024
@nex3
Add a test for an importer without a base URL
30410dd 
Closes #1970
nex3 added a commit that referenced this issue Apr 9, 2024
@nex3
Add a test for an importer without a base URL
cba9a94 
Closes #1970
nex3 added a commit that referenced this issue Apr 11, 2024
@nex3
Add a test for an importer without a base URL (#1972)
dccf461 
Closes #1970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@nex3