Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol keys #127

Open
Thomaash opened this issue May 22, 2020 · 1 comment
Open

Symbol keys #127

Thomaash opened this issue May 22, 2020 · 1 comment

Comments

@Thomaash
Copy link
Contributor

Currently it seems that symbols are simply ignored. Is this intended behavior? Wouldn't it make more sense to check them too? I would certainly appreciate it.

MWE:

// Object.assign() assigns symbols so this test should fail but it passes.
test(Object.assign, (): void => {
  const SYMBOL_KEY = Symbol("key");
  given({}, { [SYMBOL_KEY]: true }).expect({});
});
@paulmelnikow
Copy link
Collaborator

That seems reasonable. I haven't looked at this part of the code in a while (if ever!) and I'm not sure how the expectations are implemented. I imagine they are mostly delegated though I'm not sure.

Pull request welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants