Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute/Ungag Options Not Available For Perm Punishments #844

Open
fearts opened this issue Dec 31, 2022 · 4 comments
Open

Unmute/Ungag Options Not Available For Perm Punishments #844

fearts opened this issue Dec 31, 2022 · 4 comments

Comments

@fearts
Copy link

fearts commented Dec 31, 2022

What are the steps to reproduce this issue?

  1. Perm Mute/Gag someone
  2. Open website and go to that person's punishment
  3. There is no option to Unmute/Ungag them only "Add Comment" "Edit Details" "Delete Block"

If the punishment is not a Perm Mute/Gag then the Unmute/Ungag option does exist. Perm Bans have the Unban option so why do Perm Comms not have it? Without this option my head admins are unable to remove the punishment as I do not give them Delete/Edit permissions.

I'm using the php81 version of the webpanel.

Attached is a image demonstrating the issue. Thank you.

111112222

Rushaway added a commit to Rushaway/sourcebans-pp that referenced this issue Dec 31, 2022
@Rushaway Rushaway mentioned this issue Dec 31, 2022
7 tasks
@Rushaway
Copy link
Contributor

Rushaway commented May 8, 2023

@rumblefrog Your commit 358d31e re-open this issue.

@rumblefrog
Copy link
Member

@rumblefrog Your commit 358d31e re-open this issue.

Hm wasn't thinking with that one. But I'm not sure if removing the isset would be a good solution; it's creating an erroneous message every time the page is visited, so I added it back.

@rumblefrog rumblefrog reopened this May 8, 2023
@fearts
Copy link
Author

fearts commented May 9, 2023

99c1de9d7e681078eb4b30b84eb73d53
ee5c10fefb5637cb9fcd10c6957e4bdf

Yea, with the newest release this is what it looks like with the fix Rush added.

@rumblefrog
Copy link
Member

99c1de9d7e681078eb4b30b84eb73d53 ee5c10fefb5637cb9fcd10c6957e4bdf

Yea, with the newest release this is what it looks like with the fix Rush added.

That being said, warnings shouldn't be enabled in production environments. I'm not certain if that's configurable within NFO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants