addPluginSbtFile command #4211
Merged
addPluginSbtFile command #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Duhemm Looks like this could replace https://github.com/scalacenter/load-plugin for the IDE usecase. |
|
|
Fixes sbt#1502 This adds `--addPluginSbtFile=<file>` command, which adds the given .sbt file to the plugin build. Using this mechanism editors or IDEs can start a build with required plugin. ``` $ cat /tmp/extra.sbt addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.7") $ sbt --addPluginSbtFile=/tmp/extra.sbt ... sbt:helloworld> plugins In file:/xxxx/hellotest/ ... sbtassembly.AssemblyPlugin: enabled in root ```
|
Nice! |
|
Nice. Can it be set in |
nafg
reviewed
Jun 19, 2018
| @@ -96,6 +97,14 @@ $HelpCommand <regular expression> | |||
| The order is preserved between all early commands, so `sbt "early(a)" "early(b)"` executes `a` and `b` in order. | |||
| """ | |||
|
|
|||
| def addPluginSbtFileHelp = { | |||
| val brief = | |||
| (s"--$AddPluginSbtFileCommand=<file>", "Adds the given *.sbt file to the plugin build.") | |||
There was a problem hiding this comment.
aren't most options with a single dash (at least in the help)?
There was a problem hiding this comment.
The single line convention comes from Java, and since Java 9 is updating to more UNIX -- style, I am following the cargo cult.
jastice
added a commit
to jastice/sbt
that referenced
this pull request
Jul 20, 2018
1 task
jastice
added a commit
to jastice/sbt
that referenced
this pull request
Aug 23, 2018
eed3si9n
added a commit
that referenced
this pull request
Sep 20, 2018
[0.13] port sddPluginSbtFile command from #4211
1 task
|
In IntelliJ i keep getting the following, it seems it doesn't support space in a folder specification. I can't find where to change the path: |
|
@matt-leaguecio Looks like a bug in the Scala plugin. I've created an issue: |
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Nov 10, 2019
Ref sbt#4211 Fixes sbt#4395 Fixes sbt#4600 This is a reimplementation of `--addPluginSbtFile`. sbt#4211 implemented the command to load extra `*.sbt` files as part of the global plugin subproject. That had the unwanted side effects of not working when `.sbt/1.0/plugins` directory does not exist. This changes the strategy to load the `*.sbt` files as part of the meta build. ``` $ sbt -Dsbt.global.base=/tmp/hello/global --addPluginSbtFile=/tmp/plugins/plugin.sbt [info] Loading settings for project hello-build from plugin.sbt ... [info] Loading project definition from /private/tmp/hello/project sbt:hello> plugins In file:/private/tmp/hello/ sbt.plugins.IvyPlugin: enabled in root sbt.plugins.JvmPlugin: enabled in root sbt.plugins.CorePlugin: enabled in root sbt.ScriptedPlugin sbt.plugins.SbtPlugin sbt.plugins.SemanticdbPlugin: enabled in root sbt.plugins.JUnitXmlReportPlugin: enabled in root sbt.plugins.Giter8TemplatePlugin: enabled in root sbtvimquit.VimquitPlugin: enabled in root ```
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Nov 10, 2019
Ref sbt#4211 Fixes sbt#4395 Fixes sbt#4600 This is a reimplementation of `--addPluginSbtFile`. sbt#4211 implemented the command to load extra `*.sbt` files as part of the global plugin subproject. That had the unwanted side effects of not working when `.sbt/1.0/plugins` directory does not exist. This changes the strategy to load the `*.sbt` files as part of the meta build. ``` $ sbt -Dsbt.global.base=/tmp/hello/global --addPluginSbtFile=/tmp/plugins/plugin.sbt [info] Loading settings for project hello-build from plugin.sbt ... [info] Loading project definition from /private/tmp/hello/project sbt:hello> plugins In file:/private/tmp/hello/ sbt.plugins.IvyPlugin: enabled in root sbt.plugins.JvmPlugin: enabled in root sbt.plugins.CorePlugin: enabled in root sbt.ScriptedPlugin sbt.plugins.SbtPlugin sbt.plugins.SemanticdbPlugin: enabled in root sbt.plugins.JUnitXmlReportPlugin: enabled in root sbt.plugins.Giter8TemplatePlugin: enabled in root sbtvimquit.VimquitPlugin: enabled in root ```
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Nov 11, 2019
Ref sbt#4211 Fixes sbt#4395 Fixes sbt#4600 This is a reimplementation of `--addPluginSbtFile`. sbt#4211 implemented the command to load extra `*.sbt` files as part of the global plugin subproject. That had the unwanted side effects of not working when `.sbt/1.0/plugins` directory does not exist. This changes the strategy to load the `*.sbt` files as part of the meta build. ``` $ sbt -Dsbt.global.base=/tmp/hello/global --addPluginSbtFile=/tmp/plugins/plugin.sbt [info] Loading settings for project hello-build from plugin.sbt ... [info] Loading project definition from /private/tmp/hello/project sbt:hello> plugins In file:/private/tmp/hello/ sbt.plugins.IvyPlugin: enabled in root sbt.plugins.JvmPlugin: enabled in root sbt.plugins.CorePlugin: enabled in root sbt.ScriptedPlugin sbt.plugins.SbtPlugin sbt.plugins.SemanticdbPlugin: enabled in root sbt.plugins.JUnitXmlReportPlugin: enabled in root sbt.plugins.Giter8TemplatePlugin: enabled in root sbtvimquit.VimquitPlugin: enabled in root ```
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Nov 22, 2019
Ref sbt#4211 Fixes sbt#4395 Fixes sbt#4600 This is a reimplementation of `--addPluginSbtFile`. sbt#4211 implemented the command to load extra `*.sbt` files as part of the global plugin subproject. That had the unwanted side effects of not working when `.sbt/1.0/plugins` directory does not exist. This changes the strategy to load the `*.sbt` files as part of the meta build. ``` $ sbt -Dsbt.global.base=/tmp/hello/global --addPluginSbtFile=/tmp/plugins/plugin.sbt [info] Loading settings for project hello-build from plugin.sbt ... [info] Loading project definition from /private/tmp/hello/project sbt:hello> plugins In file:/private/tmp/hello/ sbt.plugins.IvyPlugin: enabled in root sbt.plugins.JvmPlugin: enabled in root sbt.plugins.CorePlugin: enabled in root sbt.ScriptedPlugin sbt.plugins.SbtPlugin sbt.plugins.SemanticdbPlugin: enabled in root sbt.plugins.JUnitXmlReportPlugin: enabled in root sbt.plugins.Giter8TemplatePlugin: enabled in root sbtvimquit.VimquitPlugin: enabled in root ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1502
This adds
--addPluginSbtFile=<file>command, which adds the given .sbt file to the plugin build.Using this mechanism editors or IDEs can start a build with required plugin.
/cc @jastice