Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade JLine #4943

Closed
eed3si9n opened this issue Aug 12, 2019 · 2 comments
Closed

Shade JLine #4943

eed3si9n opened this issue Aug 12, 2019 · 2 comments
Labels
Meta task
Milestone
1.3.0

Comments

@eed3si9n
Copy link
Member

steps

JLine in-sources JAnsi, and JLine is used by both Coursier and Scala.
lm-shaded-coursier recently leaked JLine 3 by mistake, but the same can happen with Scala in the future (scala/scala#8036).

problem

In case of #4925, it manifested itself as:

[info] [error] java.lang.NoClassDefFoundError: Could not initialize class org.fusesource.jansi.AnsiOutputStream
[info] [error] 	at jline.internal.Ansi.stripAnsi(Ansi.java:28)
[info] [error] 	at jline.console.ConsoleReader.setPrompt(ConsoleReader.java:499)
[info] [error] 	at jline.console.ConsoleReader.readLine(ConsoleReader.java:2425)
[info] [error] 	at jline.console.ConsoleReader.readLine(ConsoleReader.java:2378)
[info] [error] 	at jline.console.ConsoleReader.readLine(ConsoleReader.java:2366)

expectation

Isolate ourselves from upstream uses of JLine.
@eed3si9n eed3si9n added this to the 1.3.0 milestone Aug 16, 2019
@eed3si9n eed3si9n added the priority/blocker release blocker (used only by core team, near release time) label Aug 16, 2019
@eed3si9n
Copy link
Member Author

https://github.com/sbt/shaded-jline

eed3si9n added a commit to eed3si9n/util that referenced this issue Aug 18, 2019
@eed3si9n
use shaded JLine
c6a2e32 
Ref sbt/sbt#4943
@eed3si9n eed3si9n mentioned this issue Aug 18, 2019
Closed
eed3si9n added a commit to eed3si9n/sbt that referenced this issue Aug 18, 2019
@eed3si9n
use shaded JLine
91671e2 
Fixes sbt#4943
Ref sbt/util#209
@eed3si9n eed3si9n mentioned this issue Aug 18, 2019
Closed
@eed3si9n eed3si9n removed the priority/blocker release blocker (used only by core team, near release time) label Aug 18, 2019
@eed3si9n
Copy link
Member Author

Looks more complicated than initially thought (#4959), so I am closing this for now.

@eed3si9n eed3si9n mentioned this issue Aug 18, 2019
Closed
@eatkins eatkins mentioned this issue Nov 18, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Meta task
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

use shaded JLine eed3si9n/sbt
1 participant
@eed3si9n