Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage with EIP-1167: Minimal Proxy Contract #774

Open
Obyka opened this issue Dec 8, 2022 · 1 comment
Open

coverage with EIP-1167: Minimal Proxy Contract #774

Obyka opened this issue Dec 8, 2022 · 1 comment

Comments

@Obyka
Copy link

Obyka commented Dec 8, 2022

When using OZ implementation of EIP-1167, tests performed on clones do not count in coverage.

Here is one of my test performed on a clone:
image

Here is the relevant section in the coverage report:
image

How can I link the clone and the implementation contract coverage ?
I'm instantiating my clones using this method:
image

@wwHysenberg
Copy link

not exactly the solution you're looking for, but when I build with EIP1167s I run the tests on both the logic and proxy contracts separately. and only for the purpose of code coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants