Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests grouping name validation #3052

Open
daddykotex opened this issue May 16, 2023 · 0 comments
Open

Pull requests grouping name validation #3052

daddykotex opened this issue May 16, 2023 · 0 comments

Comments

@daddykotex
Copy link
Contributor

The configuration for pull requests grouping states that the name will be used as an identifier for things like the branch created to host the changes. Unfortunately, some characters, like spaces, are forbidden in branch names.

What would you do to prevent failure when someone uses a name like "Our common lib". Do you prefer:

  1. validation on start up which fails because the config is valid
  2. validation which warns and sanitize the name
  3. sanitize the name w/o a warning
  4. just document that you can't use spaces in name and hope users won't do that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant