Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade repl to jline 3 #11367

Closed
adriaanm opened this issue Aug 8, 2018 · 11 comments · Fixed by scala/scala#8036
Closed

upgrade repl to jline 3 #11367

adriaanm opened this issue Aug 8, 2018 · 11 comments · Fixed by scala/scala#8036
Assignees
Milestone

Comments

@adriaanm
Copy link
Contributor

adriaanm commented Aug 8, 2018

I was sure I already had a ticket, but can't find it. We should do this by RC1. The other scheduled REPL improvements will have to wait until 2.13.x.

@adriaanm adriaanm self-assigned this Aug 8, 2018
@som-snytt
Copy link

I'm looking into this today. It's non-trivial, but I'm more or less familiar with the previous state of affairs.

@fommil
Copy link

fommil commented Sep 7, 2018

@hvesalai FYI ^^^

@hvesalai
Copy link

hvesalai commented Sep 7, 2018

What what? Didn't I do this already? nope

I did this: scala/scala#6478

@fommil
Copy link

fommil commented Sep 7, 2018

@hvesalai yeah, I thought you'd be the right guy for the job 😆

@som-snytt
Copy link

I worked on this, so I'll take a look. I haven't had time the past month...

@fommil
Copy link

fommil commented Sep 7, 2018

sheesh @som-snytt , jline4 will be out by then... 😜

@adriaanm

This comment has been minimized.

@adriaanm adriaanm transferred this issue from scala/scala-dev Jan 16, 2019
@adriaanm adriaanm added this to the 2.13.1 milestone Jan 16, 2019
@adriaanm adriaanm added the repl label Jan 16, 2019
@som-snytt
Copy link

WIP scala/scala#7645

@som-snytt som-snytt mentioned this issue Jan 16, 2019
9 tasks
@adriaanm
Copy link
Contributor Author

Excellent, thanks @som-snytt!

@adriaanm adriaanm modified the milestones: 2.13.1, 2.13.0-RC1 Jan 16, 2019
@SethTisue SethTisue modified the milestones: 2.13.0-RC1, 2.13.1 Feb 20, 2019
@som-snytt
Copy link

Supersession by scala/scala#8036

also I don't even care if they red squiggly my usage of supersession.

@szeiger szeiger modified the milestones: 2.13.1, 2.13.2 Sep 9, 2019
@SethTisue SethTisue assigned SethTisue and unassigned adriaanm Feb 6, 2020
@SethTisue
Copy link
Member

SethTisue commented Feb 6, 2020

marked as blocker because we are willing to hold up 2.13.2 a bit if needed to make a serious attempt at this. (if we run into unexpectedly serious trouble, postponing remains possible.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment