Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested class shadowing in "override" position #93

Closed
eed3si9n opened this issue Mar 6, 2020 · 0 comments · Fixed by #102
Closed

Nested class shadowing in "override" position #93

eed3si9n opened this issue Mar 6, 2020 · 0 comments · Fixed by #102

Comments

@eed3si9n
Copy link
Member

eed3si9n commented Mar 6, 2020

Aloha. This is a friendly note that Community Builds has discovered a potential issue you might run into when migrating to Dotty / Scala 3.x.

Ref scala/scala#8705 / scala/bug#8353

steps

Compile using the latest 2.13.x nightly (https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/3267/) or 2.13.2 when it comes out.

sbt> set ThisBuild/resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
sbt> ++2.13.2-bin-53ba87a!
sbt> compile

problem

Community Builds discovered there are some nested classes in "override" position.

[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/ParSeqLike.scala:477:19: shadowing a nested class of a parent is deprecated but trait Accessor shadows trait Accessor defined in trait ParIterableLike; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/ParSeqLike.scala:481:19: shadowing a nested class of a parent is deprecated but trait Transformer shadows trait Transformer defined in trait ParIterableLike; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/ParSeqLike.scala:589:25: shadowing a nested class of a parent is deprecated but class Zip shadows class Zip defined in trait ParIterableLike; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/RemainsIterator.scala:566:9: shadowing a nested class of a parent is deprecated but class Taken shadows class Taken defined in trait IterableSplitter; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/RemainsIterator.scala:575:9: shadowing a nested class of a parent is deprecated but class Mapped shadows class Mapped defined in trait IterableSplitter; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/RemainsIterator.scala:583:9: shadowing a nested class of a parent is deprecated but class Appended shadows class Appended defined in trait IterableSplitter; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/RemainsIterator.scala:614:9: shadowing a nested class of a parent is deprecated but class Zipped shadows class Zipped defined in trait IterableSplitter; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/RemainsIterator.scala:622:9: shadowing a nested class of a parent is deprecated but class ZippedAll shadows class ZippedAll defined in trait IterableSplitter; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/Tasks.scala:142:9: shadowing a nested class of a parent is deprecated but trait WrappedTask shadows trait WrappedTask defined in trait Tasks; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/Tasks.scala:240:9: shadowing a nested class of a parent is deprecated but trait WrappedTask shadows trait WrappedTask defined in trait Tasks; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/Tasks.scala:303:9: shadowing a nested class of a parent is deprecated but class WrappedTask shadows trait WrappedTask defined in trait AdaptiveWorkStealingTasks; rename the class to something else
[scala-parallel-collections] [warn] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.16/project-builds/scala-parallel-collections-f822b1c94478b1fe17bb3e1abb55c379b979315e/core/src/main/scala/scala/collection/parallel/mutable/ParArray.scala:655:9: shadowing a nested class of a parent is deprecated but class Map shadows class Map defined in trait ParIterableLike; rename the class to something else

expectation

Nothing for now, but consider renaming them when you can.

SethTisue added a commit to SethTisue/scala-parallel-collections that referenced this issue May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant