Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Dotty workflow of 2022-02-03 failed #14406

Closed
github-actions bot opened this issue Feb 3, 2022 · 3 comments
Closed

Nightly Dotty workflow of 2022-02-03 failed #14406

github-actions bot opened this issue Feb 3, 2022 · 3 comments
Assignees
@nicolasstucki
Labels
itype:bug prio:blocker

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

See https://github.com/lampepfl/dotty/actions/runs/1787419773
@griggt
Copy link
Collaborator

griggt commented Feb 3, 2022

In test_non_bootstrapped:

testing that missing source file does not crash message rendering
+ clear_out /tmp/tmp.2SJpDT5RAz
+ local out=/tmp/tmp.2SJpDT5RAz
+ rm -rf '/tmp/tmp.2SJpDT5RAz/HelloWorld$.class' /tmp/tmp.2SJpDT5RAz/HelloWorld.class
+ cp tests/neg/i6371/A_1.scala /tmp/tmp.jbgSMqoF4I/A.scala
+ cp tests/neg/i6371/B_2.scala /tmp/tmp.jbgSMqoF4I/B.scala
+ /__w/dotty/dotty/project/scripts/../../project/scripts/sbt 'scalac /tmp/tmp.jbgSMqoF4I/A.scala -d /tmp/tmp.2SJpDT5RAz'
[info] welcome to sbt 1.6.1 (Private Build Java 16)
[info] loading global plugins from /root/.sbt/1.0/plugins
[info] loading settings for project dotty-build-build from build.sbt ...
[info] loading project definition from /__w/dotty/dotty/project/project
[info] loading settings for project dotty-build from build.sbt,plugins.sbt ...
[info] loading project definition from /__w/dotty/dotty/project
[info] loading settings for project scala3 from build.sbt ...
[info] resolving key references (30898 settings) ...
[info] set current project to scala3 (in build file:/__w/dotty/dotty/)
[info] running (fork) dotty.tools.dotc.Main -classpath /root/.cache/coursier/v1/https/scala-webapps.epfl.ch/artifactory/central/org/scala-lang/scala-library/2.13.8/scala-library-2.13.8.jar:/__w/dotty/dotty/library/../out/bootstrap/scala3-library-bootstrapped/scala-3.1.3-RC1-bin-SNAPSHOT-nonbootstrapped/scala3-library_3-3.1.3-RC1-bin-SNAPSHOT.jar /tmp/tmp.jbgSMqoF4I/A.scala -d /tmp/tmp.2SJpDT5RAz
[success] Total time: 6 s, completed Feb 3, 2022, 4:25:30 AM
+ rm /tmp/tmp.jbgSMqoF4I/A.scala
+ /__w/dotty/dotty/project/scripts/../../project/scripts/sbt 'scalac -classpath /tmp/tmp.2SJpDT5RAz -d /tmp/tmp.2SJpDT5RAz /tmp/tmp.jbgSMqoF4I/B.scala'
+ echo ok
+ grep -qe B.scala:2:7 /tmp/tmp.YUKBH92AMy
ok
Error: Process completed with exit code 1.

Seems to have been broken by #14002

@griggt griggt mentioned this issue Feb 4, 2022
Closed
@smarter
Copy link
Member

smarter commented Feb 5, 2022

This is an actual regression, when trying to compile B.scala with the A.scala source file missing, we get a compiler crash:

java.lang.AssertionError: assertion failed
        at scala.runtime.Scala3RunTime$.assertFailed(Scala3RunTime.scala:11)
        at dotty.tools.dotc.reporting.MessageRendering.sourceLines(MessageRendering.scala:41)
        at dotty.tools.dotc.reporting.MessageRendering.messageAndPos$$anonfun$2(MessageRendering.scala:239)
        at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
        at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
        at scala.collection.AbstractIterable.foreach(Iterable.scala:926)
        at scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:896)
        at dotty.tools.dotc.reporting.MessageRendering.messageAndPos(MessageRendering.scala:243)
        at dotty.tools.dotc.reporting.MessageRendering.messageAndPos$(MessageRendering.scala:18)
        at dotty.tools.dotc.reporting.AbstractReporter.messageAndPos(AbstractReporter.scala:8)
        at dotty.tools.dotc.reporting.ConsoleReporter$AbstractConsoleReporter.doReport(ConsoleReporter.scala:34)
        at dotty.tools.dotc.reporting.ConsoleReporter.doReport(ConsoleReporter.scala:20)
        at dotty.tools.dotc.reporting.Reporter.issueUnconfigured(Reporter.scala:154)
        at dotty.tools.dotc.reporting.Reporter.go$1(Reporter.scala:177)
        at dotty.tools.dotc.reporting.Reporter.issueIfNotSuppressed(Reporter.scala:195)
        at dotty.tools.dotc.reporting.Reporter.report(Reporter.scala:198)
        at dotty.tools.dotc.reporting.Reporter.flush$$anonfun$1(Reporter.scala:243)
        at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
        at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
        at scala.collection.immutable.List.foreach(List.scala:333)
        at dotty.tools.dotc.reporting.Reporter.flush(Reporter.scala:243)
        at dotty.tools.dotc.core.TyperState.commit(TyperState.scala:144)
        at dotty.tools.dotc.transform.TypeTestsCasts$.transformIsInstanceOf$1(TypeTestsCasts.scala:256)
        at dotty.tools.dotc.transform.TypeTestsCasts$.transformTypeTest$1(TypeTestsCasts.scala:349)
        at dotty.tools.dotc.transform.TypeTestsCasts$.interceptWith$1(TypeTestsCasts.scala:357)
        at dotty.tools.dotc.transform.TypeTestsCasts$.interceptTypeApply(TypeTestsCasts.scala:371)
        at dotty.tools.dotc.transform.Erasure$Typer.typedTypeApply(Erasure.scala:790)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2828)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.typedIf(Typer.scala:1131)
        at dotty.tools.dotc.transform.Erasure$Typer.typedIf(Erasure.scala:861)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2818)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:2990)
        at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:3013)
        at dotty.tools.dotc.transform.Erasure$Typer.typedStats(Erasure.scala:1030)
        at dotty.tools.dotc.typer.Typer.typedBlockStats(Typer.scala:1069)
        at dotty.tools.dotc.typer.Typer.typedBlock(Typer.scala:1073)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2817)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.typedLabeled(Typer.scala:1705)
        at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:2802)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2871)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.transform.Erasure$Typer.typedTyped(Erasure.scala:624)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2814)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2934)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.typedInlined(Typer.scala:1850)
        at dotty.tools.dotc.transform.Erasure$Typer.typedInlined(Erasure.scala:876)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2831)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:2990)
        at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:3013)
        at dotty.tools.dotc.transform.Erasure$Typer.typedStats(Erasure.scala:1030)
        at dotty.tools.dotc.typer.Typer.typedClassDef(Typer.scala:2454)
        at dotty.tools.dotc.transform.Erasure$Typer.typedClassDef(Erasure.scala:1020)
        at dotty.tools.dotc.typer.Typer.typedTypeOrClassDef$1(Typer.scala:2797)
        at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:2801)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2871)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:2963)
        at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:3013)
        at dotty.tools.dotc.transform.Erasure$Typer.typedStats(Erasure.scala:1030)
        at dotty.tools.dotc.typer.Typer.typedPackageDef(Typer.scala:2581)
        at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:2842)
        at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:2872)
        at dotty.tools.dotc.typer.ReTyper.typedUnadapted(ReTyper.scala:121)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2937)
        at dotty.tools.dotc.typer.Typer.typed(Typer.scala:2941)
        at dotty.tools.dotc.typer.Typer.typedExpr(Typer.scala:3057)
        at dotty.tools.dotc.transform.Erasure.run(Erasure.scala:146)
        at dotty.tools.dotc.core.Phases$Phase.runOn$$anonfun$1(Phases.scala:311)
        at scala.collection.immutable.List.map(List.scala:246)
        at dotty.tools.dotc.core.Phases$Phase.runOn(Phases.scala:312)
        at dotty.tools.dotc.Run.runPhases$1$$anonfun$1(Run.scala:259)
        at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
        at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
        at scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1328)
        at dotty.tools.dotc.Run.runPhases$1(Run.scala:270)
        at dotty.tools.dotc.Run.compileUnits$$anonfun$1(Run.scala:278)
        at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
        at dotty.tools.dotc.util.Stats$.maybeMonitored(Stats.scala:68)
        at dotty.tools.dotc.Run.compileUnits(Run.scala:287)
        at dotty.tools.dotc.Run.compileSources(Run.scala:220)
        at dotty.tools.dotc.Run.compile(Run.scala:204)
        at dotty.tools.dotc.Driver.doCompile(Driver.scala:39)
        at dotty.tools.dotc.Driver.process(Driver.scala:199)
        at dotty.tools.dotc.Driver.process(Driver.scala:167)
        at dotty.tools.dotc.Driver.process(Driver.scala:179)
        at dotty.tools.dotc.Driver.main(Driver.scala:209)
        at dotty.tools.dotc.Main.main(Main.scala)

Since I'm not sure how to fix this I will temporarily revert the PR to fix our CI.

@smarter smarter mentioned this issue Feb 5, 2022
Closed
smarter added a commit to dotty-staging/dotty that referenced this issue Feb 5, 2022
@smarter
Revert "Show inlined positions with source code"
7328a70 
This reverts commit e523c8d to fix the
CI, see scala#14406.
smarter added a commit to dotty-staging/dotty that referenced this issue Feb 5, 2022
@smarter
Revert "Show inlined positions with source code"
4e53c4e 
This temporarily reverts commit e523c8d to fix the
CI, see scala#14406.
@smarter smarter mentioned this issue Feb 5, 2022
Merged
smarter added a commit to dotty-staging/dotty that referenced this issue Feb 5, 2022
@smarter
Revert "Show inlined positions with source code"
4bcd23b 
This temporarily reverts commit e523c8d to fix the
CI, see scala#14406.
@smarter smarter mentioned this issue Feb 7, 2022
Merged
@dwijnand
Copy link
Member

#14417

olsdavis pushed a commit to olsdavis/dotty that referenced this issue Apr 4, 2022
@smarter @olsdavis
Revert "Show inlined positions with source code"
84eb162 
This temporarily reverts commit e523c8d to fix the
CI, see scala#14406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
itype:bug prio:blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smarter @dwijnand @nicolasstucki @griggt