Obsoleted modules

[kpodsiad]

Are modules such as jsonConfig210 and sbtBloop013 needed? Metals don't support earlier versions of Scala than 2.12

[tgodzik]

sbtBloop013 is need to support sbt 0.13, which is probably also why sbtBloop013 is needed. Maybe it's time we dropped 0.13 ?

[dos65]

If there is no issue then let's keep them. I don't think that dropping two modules that have few files changes the complexity.

people can always use an older version of the plugin

This requires advanced knowledge of Metals and it will take a time to found out how and which version users should set.

[kpodsiad]

There are no problems with modules alone, but every module contributes to the overall complexity - build config, CI actions, release tasks.
I understand your concerns but I'm just afraid that if we don't start cutting off deadwood we'll never be able to iterate faster.

However, it's not necessary and we can wait with removing them.

[tgodzik]

This requires advanced knowledge of Metals and it will take a time to found out how and which version users should set.

Actually it doesn't, we already hardcode the sbt-bloop version for sbt versions 1.0.0- 1.3.0, so we could do the same. If anyone adds the sbt-bloop version manually, we can mention it in the docs for them.

If there is no issue then let's keep them. I don't think that dropping two modules that have few files changes the complexity.

We can't also keep it forever, it's better to try and force users of the older versions (especially 0.13.x, which I haven't seen used in a bit) and besides Metals will correctly work with it still.

[dos65]

Actually it doesn't, we already hardcode the sbt-bloop version for sbt versions 1.0.0- 1.3.0, so we could do the same.

That is an option. Let's do that first in case if we are going to drop these modules in the next release.

[dos65]

Oops. The whole discussion was pointless because we already use 1.4.6 bloop plugin for sbt which version is less than 1.3.0 - https://github.com/scalameta/metals/blob/main/metals/src/main/scala/scala/meta/internal/builds/SbtBuildTool.scala#L158

Sorry!