Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate in time for Scala Toolkit rollout? #647

Closed
SethTisue opened this issue Apr 15, 2023 · 6 comments
Closed

Release candidate in time for Scala Toolkit rollout? #647

SethTisue opened this issue Apr 15, 2023 · 6 comments
Milestone

Comments

@SethTisue
Copy link
Contributor

SethTisue commented Apr 15, 2023

Seems like there should be an 1.0.0-RC1 before the Toolkit is announced more broadly?

I'm not sure when @szymon-rd was thinking of launching the Scala Toolkit more formally, maybe in time for Scala Days in June...?

Has there been any past discussion of the blockers are, if any, for 1.0?

I see there is a 1.0 milestone: https://github.com/scalameta/munit/issues?q=is%3Aopen+milestone%3A%22MUnit+v1.0%22+sort%3Aupdated-desc , not sure if any of these tickets are truly blockers.

cc @adpi2

@tgodzik
Copy link
Contributor

tgodzik commented Apr 17, 2023

I think the idea was to finish https://github.com/scalameta/munit/milestone/1 but I don't think anyone had a time for it. We might need to work on that before the toolkit release.

@szymon-rd
Copy link

szymon-rd commented Apr 17, 2023

@SethTisue We want to release Toolkit 0.2 first and annouce it as a public release. Then, if there is some feedback or ideas on changing the libraries, we can do it for 1.0 (the stable public release). We are also not blocked by unstable versions of libraries, but it would be really nice to have munit 1.0-RC in 0.2.

@SethTisue
Copy link
Contributor Author

maybe #650 should be considered a blocker? seems pernicious.

@SethTisue
Copy link
Contributor Author

#650 was fixed

are there any other blockers? this recently bit somebody over at VirtusLab/scala-cli#2623

@valencik
Copy link
Collaborator

In my opinion, the last remaining blocker is a final decision on reverting to the v0.7.x fixture before*/after* methods.
The current issue for that is #573
And there is a recent PR to revert to v0.7.x style here: #724

Besides documentation, this is the last thing on the v1.0 milestone as well (https://github.com/scalameta/munit/milestone/1)

@valencik
Copy link
Collaborator

1.0.0 has been released!
https://github.com/scalameta/munit/releases/tag/v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants