From adf6c7941753c030ccd28b3e14fd1903edbf7850 Mon Sep 17 00:00:00 2001 From: Albert Meltzer <7529386+kitbellew@users.noreply.github.com> Date: Sat, 16 Mar 2024 07:18:44 -0700 Subject: [PATCH] FormatOps: simplify `functionExpire` --- .../org/scalafmt/internal/FormatOps.scala | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatOps.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatOps.scala index afb54697a4..08a49c3f5b 100644 --- a/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatOps.scala +++ b/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatOps.scala @@ -921,29 +921,13 @@ class FormatOps( maxPrecedence } - def functionExpire(function: Term.FunctionTerm): (T, ExpiresOn) = { - def dropWS(rtoks: Seq[T]): Seq[T] = - rtoks.dropWhile(_.is[T.Whitespace]) - def orElse(rtoks: Seq[T]) = { - val last = rtoks.head - if (last.is[T.RightParen] && matchingOpt(last).contains(rtoks.last)) - rtoks.tail.find(!_.is[T.Whitespace]).get -> ExpiresOn.After - else - last -> ExpiresOn.After - } - def dropComment(rtoks: Seq[T]) = - if (rtoks.head.is[T.Comment]) dropWS(rtoks.tail) else rtoks - - def getRToks = dropWS(function.tokens.reverse) + def functionExpire(function: Term.FunctionTerm): (T, ExpiresOn) = function.parent match { case Some(SingleArgInBraces.OrBlock(_, _, e)) => e.left -> ExpiresOn.Before - case Some(Case(_, _, `function`)) => - orElse(dropComment(getRToks)) case _ => - orElse(getRToks) + tokens.getLastExceptParen(function).left -> ExpiresOn.After } - } def noOptimizationZones(): Set[T] = { val result = Set.newBuilder[T]