FormatOps: don't support invalid param modifiers #3482
Merged
+266
−670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala syntax prohibits repeated modifiers but the current parser doesn't yet detect the case of repeated `implicit` modifiers specifically on the first parameter. The parser change will come in scalameta v4.7.5.
Scala syntax requires `val`/`var` on parameters with explicit modifiers and the respective parser change will come in scalameta v4.7.5.
tgodzik
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, scala syntax prohibits repeated modifiers (in this case, repeated
impliciton the first parameter) and requiresvalorvaron parameters with explicit modifiers. The respective parser change will come in scalameta v4.7.5.